Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1419743003: [telemetry] Ignore missing C-state info from powermetrics. (Closed)

Created:
5 years, 2 months ago by dtu
Modified:
5 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Ignore missing C-state info from powermetrics. Our "new" Mac HDD bots have CPUs from, like, 2008, and C-states probably didn't exist back then. BUG=517580 Committed: https://crrev.com/bdbbdf659ca40c0f62c39f0b1a22083ceb9f3311 Cr-Commit-Position: refs/heads/master@{#355326}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Logging #

Patch Set 3 : Reword #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
nednguyen
lgtm
5 years, 2 months ago (2015-10-21 16:13:03 UTC) #3
aiolos (Not reviewing)
lgtm
5 years, 2 months ago (2015-10-21 16:13:17 UTC) #4
eakuefner
lgtm https://codereview.chromium.org/1419743003/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py File tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py (right): https://codereview.chromium.org/1419743003/diff/1/tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py#newcode201 tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:201: # Old CPUs don't have c-states, so if ...
5 years, 2 months ago (2015-10-21 16:13:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419743003/40001
5 years, 2 months ago (2015-10-21 16:30:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-21 17:36:35 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 17:37:58 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bdbbdf659ca40c0f62c39f0b1a22083ceb9f3311
Cr-Commit-Position: refs/heads/master@{#355326}

Powered by Google App Engine
This is Rietveld 408576698