Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 1419733003: Enable end-to-end tests for QUIC stateless rejects when they will not involve version negotiation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@105507189
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 8a3f0ca7ec7104f8a6c813ed3a0eb9cffb4df256..ae8ef09967d64b57f7197cdb6cba19c67dbbf225 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -164,10 +164,9 @@ vector<TestParams> GetTestParams() {
for (const QuicVersionVector& client_versions : client_version_buckets) {
// A number of end to end tests fail when stateless rejects are enabled
// *and* there are more than two QUIC versions.
- // TODO(b/23745998) Re-enable client stateless reject support.
- for (bool client_supports_stateless_rejects : {false}) {
- // TODO(b/23745998) Re-enable server stateless reject support.
- for (bool server_uses_stateless_rejects_if_peer_supported : {false}) {
+ for (bool client_supports_stateless_rejects : {true, false}) {
+ for (bool server_uses_stateless_rejects_if_peer_supported :
+ {true, false}) {
for (bool auto_tune_flow_control_window : {true, false}) {
CHECK(!client_versions.empty());
// Add an entry for server and client supporting all versions.
@@ -177,6 +176,12 @@ vector<TestParams> GetTestParams() {
client_supports_stateless_rejects,
server_uses_stateless_rejects_if_peer_supported,
congestion_control_tag, auto_tune_flow_control_window));
+ if (client_supports_stateless_rejects &&
+ server_uses_stateless_rejects_if_peer_supported) {
+ // TODO(b/23745998) Make stateless reject work with version
+ // negotiation.
+ continue;
+ }
// Test client supporting all versions and server supporting 1
// version. Simulate an old server and exercise version downgrade
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698