Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge to head, address jyasskin's comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 63ae5f5c2859ac70bf5cc6024f223f959d4f8deb..dd0cd91a3b22649d6d220cb97d1641ddb20e26d9 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -235,28 +235,18 @@ class TestInterstitialPageStateGuard : public TestInterstitialPage::Delegate {
class WebContentsImplTest : public RenderViewHostImplTestHarness {
public:
- WebContentsImplTest()
- : ui_thread_(BrowserThread::UI, &message_loop_),
- file_user_blocking_thread_(
- BrowserThread::FILE_USER_BLOCKING, &message_loop_),
- io_thread_(BrowserThread::IO, &message_loop_) {
- }
-
virtual void SetUp() {
RenderViewHostImplTestHarness::SetUp();
WebUIControllerFactory::RegisterFactory(&factory_);
}
virtual void TearDown() {
- RenderViewHostImplTestHarness::TearDown();
WebUIControllerFactory::UnregisterFactoryForTesting(&factory_);
+ RenderViewHostImplTestHarness::TearDown();
}
private:
WebContentsImplTestWebUIControllerFactory factory_;
- TestBrowserThread ui_thread_;
- TestBrowserThread file_user_blocking_thread_;
- TestBrowserThread io_thread_;
};
class TestWebContentsObserver : public WebContentsObserver {

Powered by Google App Engine
This is Rietveld 408576698