content/browser/devtools/devtools_manager_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge to head, address jyasskin's comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_thread_impl.cc ('K') | « content/browser/browser_thread_impl.cc ('k') | content/browser/download/save_package_unittest.cc » ('j') | content/public/test/test_browser_thread_bundle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_manager_unittest.cc

diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc

index 6923a9379c76bad207772c00fac8b1c7979f8cc1..4053db7886aa502e5f9c4d574ee316a51d3ea402 100644

--- a/content/browser/devtools/devtools_manager_unittest.cc

+++ b/content/browser/devtools/devtools_manager_unittest.cc

@@ -106,10 +106,6 @@ class DevToolsManagerTestBrowserClient : public TestContentBrowserClient {

} // namespace

class DevToolsManagerTest : public RenderViewHostImplTestHarness {

- public:

- DevToolsManagerTest() {

- }

protected:

virtual void SetUp() OVERRIDE {

original_browser_client_ = SetBrowserClientForTesting(&browser_client_);