Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4938)

Unified Diff: chrome/browser/ui/tabs/tab_strip_model_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address jyasskin's comments\ Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tabs/tab_strip_model_unittest.cc
diff --git a/chrome/browser/ui/tabs/tab_strip_model_unittest.cc b/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
index da20cc9a0988021b0b3b1bf11f45899a87426f6a..47b454b602b164b7ca7b428fa290e2be4ec494c4 100644
--- a/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
+++ b/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
@@ -36,10 +36,8 @@
#include "content/public/browser/notification_source.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
-using content::BrowserThread;
using content::SiteInstance;
using content::WebContents;
using extensions::Extension;
@@ -108,9 +106,6 @@ class TabStripModelTestIDUserData : public base::SupportsUserData::Data {
class TabStripModelTest : public ChromeRenderViewHostTestHarness {
public:
- TabStripModelTest() : browser_thread_(BrowserThread::UI, &message_loop_) {
- }
-
WebContents* CreateWebContents() {
return WebContents::Create(WebContents::CreateParams(profile()));
}
@@ -197,9 +192,6 @@ class TabStripModelTest : public ChromeRenderViewHostTestHarness {
selection_model.set_active(selection_model.selected_indices()[0]);
model->SetSelectionFromModel(selection_model);
}
-
- private:
- content::TestBrowserThread browser_thread_;
};
class MockTabStripModelObserver : public TabStripModelObserver {

Powered by Google App Engine
This is Rietveld 408576698