chrome/browser/translate/translate_manager_browsertest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address jyasskin's comments\ Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/activity_database_unittest.cc ('K') | « chrome/browser/tab_contents/render_view_context_menu_unittest.cc ('k') | chrome/browser/ui/ash/launcher/browser_launcher_item_controller_unittest.cc » ('j') | content/public/test/test_renderer_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_browsertest.cc

diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc

index 2ed6ed052a73811e02309493e580c3c1767455b3..2d509a55864a6b32a3d1334b58f9262be5565e2a 100644

--- a/chrome/browser/translate/translate_manager_browsertest.cc

+++ b/chrome/browser/translate/translate_manager_browsertest.cc

@@ -44,7 +44,6 @@

#include "content/public/test/mock_notification_observer.h"

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/render_view_test.h"

-#include "content/public/test/test_browser_thread.h"

#include "content/public/test/test_renderer_host.h"

#include "grit/generated_resources.h"

#include "ipc/ipc_test_sink.h"

@@ -54,7 +53,6 @@

#include "third_party/WebKit/Source/WebKit/chromium/public/WebKit.h"

#include "third_party/cld/languages/public/languages.h"

-using content::BrowserThread;

using content::NavigationController;

using content::RenderViewHostTester;

using content::WebContents;

@@ -98,8 +96,7 @@ class TranslateManagerBrowserTest : public ChromeRenderViewHostTestHarness,

TranslateManagerBrowserTest()

: pref_callback_(

base::Bind(&TranslateManagerBrowserTest::OnPreferenceChanged,

- base::Unretained(this))),

- ui_thread_(BrowserThread::UI, &message_loop_) {

+ base::Unretained(this))) {

}

// Simulates navigating to a page and getting the page contents and language

@@ -310,7 +307,6 @@ class TranslateManagerBrowserTest : public ChromeRenderViewHostTestHarness,

private:

content::NotificationRegistrar notification_registrar_;

net::TestURLFetcherFactory url_fetcher_factory_;

- content::TestBrowserThread ui_thread_;

content::RenderViewTest::RendererWebKitPlatformSupportImplNoSandbox

webkit_platform_support_;