chrome/browser/automation/automation_tab_helper_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_tab_helper_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address jyasskin's comments\ Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc » ('j') | chrome/browser/extensions/activity_log/activity_database_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_tab_helper_unittest.cc

diff --git a/chrome/browser/automation/automation_tab_helper_unittest.cc b/chrome/browser/automation/automation_tab_helper_unittest.cc

index 4f175e84638fc63e7011c14e9d1032cf6f697b7e..49e7831d6c817a0eadd0fd96a40127ec2e6082ac 100644

--- a/chrome/browser/automation/automation_tab_helper_unittest.cc

+++ b/chrome/browser/automation/automation_tab_helper_unittest.cc

@@ -17,11 +17,7 @@ using testing::_;

class AutomationTabHelperTest : public ChromeRenderViewHostTestHarness {

public:

- AutomationTabHelperTest()

- : ChromeRenderViewHostTestHarness(),

- browser_thread_(BrowserThread::UI, &message_loop_) {}

- virtual void SetUp() {

+ virtual void SetUp() OVERRIDE {

ChromeRenderViewHostTestHarness::SetUp();

AutomationTabHelper::CreateForWebContents(web_contents());

mock_observer_.StartObserving(tab_helper());

@@ -54,8 +50,6 @@ class AutomationTabHelperTest : public ChromeRenderViewHostTestHarness {

return AutomationTabHelper::FromWebContents(web_contents());

}

- content::TestBrowserThread browser_thread_;

MockTabEventObserver mock_observer_;

};