chrome/browser/web_applications/web_app_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/web_app_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: platform specific dchecks should be platform specific Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller_unittest.cc ('k') | chrome/test/base/chrome_render_view_host_test_harness.cc » ('j') | content/public/test/test_browser_thread_bundle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_applications/web_app_unittest.cc

diff --git a/chrome/browser/web_applications/web_app_unittest.cc b/chrome/browser/web_applications/web_app_unittest.cc

index 149f62b9b73c6a98952016e5856c5473cbf76e39..a8a760cf2e22d430e868b17a77bb4dc94572b423 100644

--- a/chrome/browser/web_applications/web_app_unittest.cc

+++ b/chrome/browser/web_applications/web_app_unittest.cc

@@ -12,26 +12,18 @@

#include "chrome/browser/ui/web_applications/web_app_ui.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

-#include "content/public/test/test_browser_thread.h"

#include "content/public/test/test_renderer_host.h"

#include "testing/gtest/include/gtest/gtest.h"

-using content::BrowserThread;

using content::RenderViewHostTester;

class WebApplicationTest : public ChromeRenderViewHostTestHarness {

- public:

- WebApplicationTest() : ui_thread_(BrowserThread::UI, &message_loop_) {

- }

- private:

+ protected:

virtual void SetUp() OVERRIDE {

ChromeRenderViewHostTestHarness::SetUp();

extensions::TabHelper::CreateForWebContents(web_contents());

FaviconTabHelper::CreateForWebContents(web_contents());

}

- content::TestBrowserThread ui_thread_;

};

#if defined(OS_MACOSX)