chrome/browser/net/sqlite_server_bound_cert_store.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/sqlite_server_bound_cert_store.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merged ToT Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/http_pipelining_compatibility_client_unittest.cc ('k') | chrome/browser/net/sqlite_server_bound_cert_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/sqlite_server_bound_cert_store.cc

diff --git a/chrome/browser/net/sqlite_server_bound_cert_store.cc b/chrome/browser/net/sqlite_server_bound_cert_store.cc

index 0ba32a417b3936e910def62410419fef0d9bb865..674be57f34c58d465f46ff3b79fed6bda8fa9903 100644

--- a/chrome/browser/net/sqlite_server_bound_cert_store.cc

+++ b/chrome/browser/net/sqlite_server_bound_cert_store.cc

@@ -479,7 +479,6 @@ void SQLiteServerBoundCertStore::Backend::BatchOperation(

static const int kCommitIntervalMs = 30 * 1000;

// Commit right away if we have more than 512 outstanding operations.

static const size_t kCommitAfterBatchSize = 512;

- DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::DB));

// We do a full copy of the cert here, and hopefully just here.

scoped_ptr<PendingOperation> po(new PendingOperation(op, cert));

@@ -574,7 +573,6 @@ void SQLiteServerBoundCertStore::Backend::Commit() {

// pending commit timer that will be holding a reference on us, but if/when

// this fires we will already have been cleaned up and it will be ignored.

void SQLiteServerBoundCertStore::Backend::Close() {

- DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::DB));

// Must close the backend on the background thread.

BrowserThread::PostTask(

BrowserThread::DB, FROM_HERE,