chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merged ToT Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/media_file_system_registry_unittest.cc ('k') | chrome/browser/net/chrome_network_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc

diff --git a/chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc b/chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc

index 902d9a3207c6ba939ff709d4eb6f9ad475e71f3e..a1b394f32044e3e9797ebdd4384708ce6ebf2637 100644

--- a/chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc

+++ b/chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc

@@ -9,7 +9,7 @@

#include "base/message_loop.h"

#include "base/run_loop.h"

#include "content/public/browser/browser_thread.h"

-#include "content/public/test/test_browser_thread.h"

+#include "content/public/test/test_browser_thread_bundle.h"

#include "net/base/test_completion_callback.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -20,8 +20,7 @@ namespace pnacl_cache {

class PNaClTranslationCacheTest : public testing::Test {

protected:

PNaClTranslationCacheTest()

- : cache_thread_(BrowserThread::CACHE, &message_loop_),

- io_thread_(BrowserThread::IO, &message_loop_) {}

+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}

virtual ~PNaClTranslationCacheTest() {}

virtual void SetUp() { cache_ = new PNaClTranslationCache(); }

virtual void TearDown() {

@@ -36,9 +35,7 @@ class PNaClTranslationCacheTest : public testing::Test {

protected:

PNaClTranslationCache* cache_;

- base::MessageLoopForIO message_loop_;

- content::TestBrowserThread cache_thread_;

- content::TestBrowserThread io_thread_;

+ content::TestBrowserThreadBundle thread_bundle_;

};

TEST_F(PNaClTranslationCacheTest, StoreOneInMem) {