chrome/browser/extensions/active_tab_unittest.cc - Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merged ToT Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_target_determiner_unittest.cc ('k') | chrome/browser/extensions/activity_log/activity_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_tab_unittest.cc

diff --git a/chrome/browser/extensions/active_tab_unittest.cc b/chrome/browser/extensions/active_tab_unittest.cc

index 27ac325f0fdb5d626af1bc997ea9453fb8ae5a03..505ce28cdb44cdbc2b802b909f3fbb3c1524c8a0 100644

--- a/chrome/browser/extensions/active_tab_unittest.cc

+++ b/chrome/browser/extensions/active_tab_unittest.cc

@@ -54,14 +54,12 @@ scoped_refptr<const Extension> CreateTestExtension(

}

class ActiveTabTest : public ChromeRenderViewHostTestHarness {

- public:

+ protected:

ActiveTabTest()

: extension(CreateTestExtension("deadbeef", true)),

another_extension(CreateTestExtension("feedbeef", true)),

- extension_without_active_tab(CreateTestExtension("badbeef", false)),

- ui_thread_(BrowserThread::UI, base::MessageLoop::current()) {}

+ extension_without_active_tab(CreateTestExtension("badbeef", false)) {}

- protected:

virtual void SetUp() OVERRIDE {

ChromeRenderViewHostTestHarness::SetUp();

TabHelper::CreateForWebContents(web_contents());

@@ -124,9 +122,6 @@ class ActiveTabTest : public ChromeRenderViewHostTestHarness {

// An extension without the activeTab permission.

scoped_refptr<const Extension> extension_without_active_tab;

- private:

- content::TestBrowserThread ui_thread_;

};

TEST_F(ActiveTabTest, GrantToSinglePage) {