Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6902)

Unified Diff: chrome/browser/extensions/activity_log/activity_database_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Provisional push for gbillock Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_database_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_database_unittest.cc b/chrome/browser/extensions/activity_log/activity_database_unittest.cc
index 8d73398c5220a459eb264383f562b6cf2ca4ed86..3f32eae5e3b06ae5250563f54f268a1c3d9c20e6 100644
--- a/chrome/browser/extensions/activity_log/activity_database_unittest.cc
+++ b/chrome/browser/extensions/activity_log/activity_database_unittest.cc
@@ -38,13 +38,11 @@ namespace extensions {
class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
public:
- ActivityDatabaseTest()
- : ui_thread_(BrowserThread::UI, MessageLoop::current()),
- db_thread_(BrowserThread::DB, MessageLoop::current()),
- file_thread_(BrowserThread::FILE, MessageLoop::current()) {}
-
virtual void SetUp() OVERRIDE {
ChromeRenderViewHostTestHarness::SetUp();
+#if defined OS_CHROMEOS
+ test_user_manager_.reset(new chromeos::ScopedTestUserManager());
+#endif
CommandLine command_line(CommandLine::NO_PROGRAM);
profile_ =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
@@ -55,9 +53,11 @@ class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
switches::kEnableExtensionActivityLogTesting);
}
- virtual ~ActivityDatabaseTest() {
- MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
- MessageLoop::current()->Run();
+ virtual void TearDown() OVERRIDE {
+#if defined OS_CHROMEOS
+ test_user_manager_.reset();
+#endif
+ ChromeRenderViewHostTestHarness::TearDown();
}
protected:
@@ -65,15 +65,11 @@ class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
Profile* profile_;
private:
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread db_thread_;
- content::TestBrowserThread file_thread_;
-
#if defined OS_CHROMEOS
chromeos::ScopedStubCrosEnabler stub_cros_enabler_;
chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
chromeos::ScopedTestCrosSettings test_cros_settings_;
- chromeos::ScopedTestUserManager test_user_manager_;
+ scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
#endif
};

Powered by Google App Engine
This is Rietveld 408576698