Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads.

chrome/browser/extensions/activity_log/activity_database_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/run_loop.h"
@@ skipping 20 matching lines @@
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chromeos/chromeos_switches.h"
 #endif
 
 namespace extensions {
 
 class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
  public:
-  ActivityDatabaseTest()
-      : ui_thread_(BrowserThread::UI, MessageLoop::current()),
-        db_thread_(BrowserThread::DB, MessageLoop::current()),
-        file_thread_(BrowserThread::FILE, MessageLoop::current()) {}
-
   virtual void SetUp() OVERRIDE {
     ChromeRenderViewHostTestHarness::SetUp();
+#if defined OS_CHROMEOS
+    test_user_manager_.reset(new chromeos::ScopedTestUserManager());

[Jeffrey Yasskin, 2013/05/27 03:12:13]

I don't like having to move value objects into scoped_ptrs, especially if you're
also required to manually destroy them in TearDown(). I guess you had to do this
in order to allow SetRealThreadMask() to control the thread startup. You could
give RenderViewHostTestHarness a constructor with an argument, but that's pretty
uncommon. All the more reason that designing testing utilities to require
inheritance is a bad idea, I guess.

[awong, 2013/05/30 21:46:09]

Yeah. All choices are bad.
  (1) We can't move all initialization into the constructor 
      due to harness initialization ordering issues 
      listed in CL.
  (2) We can't call RVHTH::SetUp() in the constructor 
      because it's virtual which, while legally doable, has 
      subtle behavior that will likely bite most people.
  (3) If we add a parameter to the constructor, then we have
      split duties for harness initialization between the
      constructor and the SetUp() method.

Basically, because RVHTH is invoked via inheritance, the initialization order is
constrained which makes this API wart hard to fix.

+#endif
     CommandLine command_line(CommandLine::NO_PROGRAM);
     profile_ =
         Profile::FromBrowserContext(web_contents()->GetBrowserContext());
     extension_service_ = static_cast<TestExtensionSystem*>(
         ExtensionSystem::Get(profile_))->CreateExtensionService(
             &command_line, base::FilePath(), false);
     CommandLine::ForCurrentProcess()->AppendSwitch(
         switches::kEnableExtensionActivityLogTesting);
   }
 
-  virtual ~ActivityDatabaseTest() {
-    MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
-    MessageLoop::current()->Run();
+  virtual void TearDown() OVERRIDE {
+#if defined OS_CHROMEOS
+    test_user_manager_.reset();
+#endif
+    ChromeRenderViewHostTestHarness::TearDown();
   }
 
  protected:
   ExtensionService* extension_service_;
   Profile* profile_;
 
  private:
-  content::TestBrowserThread ui_thread_;
-  content::TestBrowserThread db_thread_;
-  content::TestBrowserThread file_thread_;
-
 #if defined OS_CHROMEOS
   chromeos::ScopedStubCrosEnabler stub_cros_enabler_;
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
-  chromeos::ScopedTestUserManager test_user_manager_;
+  scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
 #endif
 
 };
 
 
 // Check that the database is initialized properly.
 TEST_F(ActivityDatabaseTest, Init) {
   base::ScopedTempDir temp_dir;
   base::FilePath db_file;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
@@ skipping 308 matching lines @@
       APIAction::CALL,
       "brewster",
       "woooof",
       "extra");
   activity_db->RecordAction(action);
   activity_db->Close();
 }
 
 }  // namespace