[MD] Twiddle padding of omnibox chips

[MD] Twiddle padding of omnibox chips

Separate out pre-MD from MD logic for the sake of my sanity.

BUG=552562
Committed: https://crrev.com/e40fbd0e0083b17c3e5c398a448fb7c70a1c8267
Cr-Commit-Position: refs/heads/master@{#358510}

[Evan Stade, 2015-11-07 02:14:18]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-11-07 02:36:21]

LGTM

https://codereview.chromium.org/1419673017/diff/1/chrome/browser/ui/views/lay...
File chrome/browser/ui/views/layout_constants.cc (right):

https://codereview.chromium.org/1419673017/diff/1/chrome/browser/ui/views/lay...
chrome/browser/ui/views/layout_constants.cc:15: const int
kIconLabelViewLeadingPadding[] = {-99, 2, 2};
If this isn't used pre-MD, then don't use LayoutConstants for it; define a
constant in IconLabelBubbleView::GetBubbleOuterPaddingMd() instead.

[Evan Stade, 2015-11-07 03:10:12]

https://codereview.chromium.org/1419673017/diff/1/chrome/browser/ui/views/lay...
File chrome/browser/ui/views/layout_constants.cc (right):

https://codereview.chromium.org/1419673017/diff/1/chrome/browser/ui/views/lay...
chrome/browser/ui/views/layout_constants.cc:15: const int
kIconLabelViewLeadingPadding[] = {-99, 2, 2};
On 2015/11/07 02:36:21, Peter Kasting wrote:
> If this isn't used pre-MD, then don't use LayoutConstants for it; define a
> constant in IconLabelBubbleView::GetBubbleOuterPaddingMd() instead.

Done.

[Evan Stade, 2015-11-07 03:10:16]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-11-07 03:10:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1419673017/#ps20001
(title: "move constant to inline")

[commit-bot: I haz the power, 2015-11-07 03:10:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419673017/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419673017/20001

[commit-bot: I haz the power, 2015-11-07 03:44:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-07 03:45:39]

Patchset 2 (id:??) landed as
https://crrev.com/e40fbd0e0083b17c3e5c398a448fb7c70a1c8267
Cr-Commit-Position: refs/heads/master@{#358510}