Remove usage of compat from client

Remove usage of compat from client

When used in client headers, the downstream dependency on compat
is unpleasant, so avoid that.

This is another alternative rather than
https://codereview.chromium.org/1424443002/.

R=mark@chromium.org
BUG=chromium:546288, crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a43323a1bf0613073ce02316e87268b14e8057d3

[scottmg, 2015-10-22 20:00:59]

I think this one is probably preferable?

[Mark Mentovai, 2015-10-22 20:13:48]

LGTM

I do think it’s OK for implementations in client to depend on compat, but it
doesn’t look like we have any of that.

I have a suspicion that ssize_ts spread out further to callers of these things,
and we might want to follow through with FileOperationResult there, or wall it
off with some static_asserts that FileOperationResult and ssize_t are the same.

[scottmg, 2015-10-22 20:55:56]

Description was changed from

==========
Remove usage of compat from client

This is another alternative rather than
https://codereview.chromium.org/1424443002/.

R=mark@chromium.org
BUG=chromium:546288, crashpad:1
==========

to

==========
Remove usage of compat from client

When used in client headers, the downstream dependency on compat
is unpleasant, so avoid that.

This is another alternative rather than
https://codereview.chromium.org/1424443002/.

R=mark@chromium.org
BUG=chromium:546288, crashpad:1
==========

[scottmg, 2015-10-22 20:58:25]

On 2015/10/22 20:13:48, Mark Mentovai wrote:
> LGTM
> 
> I do think it’s OK for implementations in client to depend on compat, but it
> doesn’t look like we have any of that.
> 
> I have a suspicion that ssize_ts spread out further to callers of these
things,
> and we might want to follow through with FileOperationResult there, or wall it
> off with some static_asserts that FileOperationResult and ssize_t are the
same.

Hmm. :/
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/crashp...

[scottmg, 2015-10-22 21:01:41]

Committed patchset #1 (id:1) manually as
a43323a1bf0613073ce02316e87268b14e8057d3 (presubmit successful).