More options file validation (and API iteration).

More options file validation (and API iteration).

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/b1215d77183e4e8306151177ca6ecbc550666f94

[pquitslund, 2015-10-22 17:48:25]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[pquitslund, 2015-10-22 17:48:26]

Comments welcome on the following proposed API:

/// Validates options.
abstract class OptionsValidator {
  /// Validate [options], reporting any errors to the given [reporter].
  void validate(ErrorReporter reporter, Map<String, YamlNode> options);
}

If it passes muster, I'll add more docs and expose it via an extension point.

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:91: /// TODO(pq): move into `linter`
package and plugin.
Or maybe to a server-hosted linter plugin.  (In any event OUT of here!)

[Brian Wilkerson, 2015-10-22 20:00:16]

LGTM

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:125: final List<String> supportedOptions;
Might be interesting to eventually make this a map from option names to a
validator function/option to be applied to the value.

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:133: if (k is YamlScalar) {
Is it an error if the key is not a scalar value? (If so, a TODO to report the
error would be fine.)

[pquitslund, 2015-10-22 20:19:26]

Thanks!

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:125: final List<String> supportedOptions;
On 2015/10/22 20:00:15, Brian Wilkerson wrote:
> Might be interesting to eventually make this a map from option names to a
> validator function/option to be applied to the value.

Good idea!

https://codereview.chromium.org/1419673006/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:133: if (k is YamlScalar) {
On 2015/10/22 20:00:15, Brian Wilkerson wrote:
> Is it an error if the key is not a scalar value? (If so, a TODO to report the
> error would be fine.)

Done.

[pquitslund, 2015-10-22 20:20:19]

Committed patchset #1 (id:1) manually as
b1215d77183e4e8306151177ca6ecbc550666f94 (presubmit successful).