Cast Media Router: add Debug Log messages and mark some error messages as such.

Cast Media Router: add Debug Log messages and mark some error messages as such.

Log.d() are stripped on non-debug builds. This is adding a few such logs to
find out which messages are sent/received. It is also moving some Log.d() to
Log.e() so these messages will still be printed on release builds.

BUG=None

Committed: https://crrev.com/5206f213a0e5cebdbbd157c03dbbeab61900823c
Cr-Commit-Position: refs/heads/master@{#357091}

[mlamouri (slow - plz ping), 2015-10-30 10:20:16]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2015-10-30 11:30:27]

lgtm with a couple of suggestions on the messaging.

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java
(right):

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java:322:
Log.d(TAG, "Received message from Cast: type=\"" + type + "\" message=\"" +
message + "\"");
I'd rather call it "Sending message to the SDK clients: " since it can be an
internal message we generate (e.g. new_session, remove_session, etc). "Cast" is
not something that can send messages either.

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java:524:
Log.d(TAG, "Sending message to Cast: " + message);
s/to Cast/to device?

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java:592:
Log.d(TAG, "Sending message to client: " + json);
Isn't this redundant with onMessage logging?

[mlamouri (slow - plz ping), 2015-10-30 11:34:02]

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java
(right):

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java:322:
Log.d(TAG, "Received message from Cast: type=\"" + type + "\" message=\"" +
message + "\"");
On 2015/10/30 at 11:30:26, whywhat wrote:
> I'd rather call it "Sending message to the SDK clients: " since it can be an
internal message we generate (e.g. new_session, remove_session, etc). "Cast" is
not something that can send messages either.

That's correct. But I want to log raw messages we receive and messages we
actually send back.

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java:524:
Log.d(TAG, "Sending message to Cast: " + message);
On 2015/10/30 at 11:30:26, whywhat wrote:
> s/to Cast/to device?

Why not calling it "Cast"? The class is "CastRouteController".

https://codereview.chromium.org/1419663009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastRouteController.java:592:
Log.d(TAG, "Sending message to client: " + json);
On 2015/10/30 at 11:30:26, whywhat wrote:
> Isn't this redundant with onMessage logging?

The messages aren't exactly the same and I want us to be able to see the
difference. Basically, the difference between onMessage() logging and this one
is the processing Chrome is doing.

[mlamouri (slow - plz ping), 2015-10-30 12:45:31]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-10-30 12:45:31]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/1419663009/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2015-10-30 12:45:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419663009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419663009/20001

[commit-bot: I haz the power, 2015-10-30 13:26:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-30 13:27:22]

Patchset 2 (id:??) landed as
https://crrev.com/5206f213a0e5cebdbbd157c03dbbeab61900823c
Cr-Commit-Position: refs/heads/master@{#357091}