core/src/fpdfapi/fpdf_render/fpdf_render.cpp - Issue 1419643005: Merge to XFA: Add type cast definitions for CPDF_Array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render.cpp

Issue 1419643005: Merge to XFA: Add type cast definitions for CPDF_Array. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_render/fpdf_render.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render.cpp

index 99835a3b94daa71eacf296082701898bd5b65622..7b37b1b9bd5a6ff40dabdc629821283976dce3fe 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render.cpp

@@ -1225,9 +1225,8 @@ CPDF_TransferFunc* CPDF_DocRenderData::GetTransferFunc(CPDF_Object* pObj) {

CPDF_Function* pFuncs[3] = {nullptr, nullptr, nullptr};

FX_BOOL bUniTransfer = TRUE;

FX_BOOL bIdentity = TRUE;

- if (pObj->GetType() == PDFOBJ_ARRAY) {

+ if (CPDF_Array* pArray = pObj->AsArray()) {

bUniTransfer = FALSE;

- CPDF_Array* pArray = (CPDF_Array*)pObj;

if (pArray->GetCount() < 3)

return nullptr;