core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp - Issue 1419643005: Merge to XFA: Add type cast definitions for CPDF_Array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

Issue 1419643005: Merge to XFA: Add type cast definitions for CPDF_Array. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

index c98f8da56faac91d59a528892948f1189af80917..238347a6615690e59981c020249ead2ccb8c513f 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp

@@ -305,7 +305,7 @@ FX_BOOL CPDF_Document::IsContentUsedElsewhere(FX_DWORD objnum,

continue;

}

if (pContents->GetDirectType() == PDFOBJ_ARRAY) {

- CPDF_Array* pArray = (CPDF_Array*)pContents->GetDirect();

+ CPDF_Array* pArray = pContents->GetDirect()->AsArray();

for (FX_DWORD j = 0; j < pArray->GetCount(); j++) {

CPDF_Object* pRef = pArray->GetElement(j);

if (pRef == NULL || pRef->GetType() != PDFOBJ_REFERENCE) {