Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: base/trace_event/memory_profiler_allocation_context_unittest.cc

Issue 1419633004: [Tracing] Introduce HeapDumpWriter helper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove WriteStackFrames, DISALLOW_COPY_AND_ASSIGN Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_profiler_allocation_context_unittest.cc
diff --git a/base/trace_event/memory_profiler_allocation_context_unittest.cc b/base/trace_event/memory_profiler_allocation_context_unittest.cc
index 3af3e6b9cf1982d584328a16432f261b063d2f5b..07b40d147d05be42707d3e2f179f14a0fa236ef7 100644
--- a/base/trace_event/memory_profiler_allocation_context_unittest.cc
+++ b/base/trace_event/memory_profiler_allocation_context_unittest.cc
@@ -231,7 +231,7 @@ TEST_F(AllocationContextTest, BacktraceTakesTop) {
}
TEST_F(StackFrameDeduplicatorTest, SingleBacktrace) {
- AllocationContext::Backtrace bt = {
+ Backtrace bt = {
Primiano Tucci (use gerrit) 2015/10/26 11:52:06 If the problem is breaking lines here you can just
Ruud van Asseldonk 2015/10/26 14:51:26 That is what I did at first but then I though I mi
{kBrowserMain, kCreateWidget, kMalloc, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
// The call tree should look like this (index in brackets).
@@ -260,10 +260,8 @@ TEST_F(StackFrameDeduplicatorTest, SingleBacktrace) {
// frames). Also verify that frames with the same name but a different caller
// are represented as distinct nodes.
TEST_F(StackFrameDeduplicatorTest, MultipleRoots) {
- AllocationContext::Backtrace bt0 = {
- {kBrowserMain, kCreateWidget, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
- AllocationContext::Backtrace bt1 = {
- {kRendererMain, kCreateWidget, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
+ Backtrace bt0 = {{kBrowserMain, kCreateWidget, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
+ Backtrace bt1 = {{kRendererMain, kCreateWidget, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
// The call tree should look like this (index in brackets).
//
@@ -295,10 +293,8 @@ TEST_F(StackFrameDeduplicatorTest, MultipleRoots) {
}
TEST_F(StackFrameDeduplicatorTest, Deduplication) {
- AllocationContext::Backtrace bt0 = {
- {kBrowserMain, kCreateWidget, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
- AllocationContext::Backtrace bt1 = {
- {kBrowserMain, kInitialize, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
+ Backtrace bt0 = {{kBrowserMain, kCreateWidget, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
+ Backtrace bt1 = {{kBrowserMain, kInitialize, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}};
// The call tree should look like this (index in brackets).
//

Powered by Google App Engine
This is Rietveld 408576698