base/trace_event/BUILD.gn - Issue 1419633004: [Tracing] Introduce HeapDumpWriter helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/BUILD.gn

Issue 1419633004: [Tracing] Introduce HeapDumpWriter helper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address primiano comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/BUILD.gn

diff --git a/base/trace_event/BUILD.gn b/base/trace_event/BUILD.gn

index edb3c7c65cbce517a10c8f96e345dff9125b9fea..4cbbcd09caa7737e75dea1c42a2cdb92695b31f1 100644

--- a/base/trace_event/BUILD.gn

+++ b/base/trace_event/BUILD.gn

@@ -24,6 +24,8 @@ source_set("trace_event") {

"memory_profiler_allocation_register.h",

"memory_profiler_allocation_register_posix.cc",

"memory_profiler_allocation_register_win.cc",

+ "memory_profiler_heap_dump_writer.cc",

+ "memory_profiler_heap_dump_writer.h",

"process_memory_dump.cc",

"process_memory_dump.h",

"process_memory_maps.cc",