minidump/minidump_memory_info_writer_test.cc - Issue 1419623003: Write MINIDUMP_HANDLE_DATA_STREAM to minidump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_memory_info_writer_test.cc

Issue 1419623003: Write MINIDUMP_HANDLE_DATA_STREAM to minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_memory_info_writer_test.cc

diff --git a/minidump/minidump_memory_info_writer_test.cc b/minidump/minidump_memory_info_writer_test.cc

index 21081d53d876c1c1fd909059661b4fc967db39a5..b2ff4a865fe2b8916cbfd3ee7070f2eb1c19b8cf 100644

--- a/minidump/minidump_memory_info_writer_test.cc

+++ b/minidump/minidump_memory_info_writer_test.cc

@@ -51,7 +51,7 @@ void GetMemoryInfoListStream(

*memory_info_list =

MinidumpWritableAtLocationDescriptor<MINIDUMP_MEMORY_INFO_LIST>(

file_contents, directory[kDirectoryIndex].Location);

- ASSERT_TRUE(memory_info_list);

+ ASSERT_TRUE(*memory_info_list);

}

TEST(MinidumpMemoryInfoWriter, Empty) {