Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: minidump/minidump_file_writer.cc

Issue 1419623003: Write MINIDUMP_HANDLE_DATA_STREAM to minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_file_writer.cc
diff --git a/minidump/minidump_file_writer.cc b/minidump/minidump_file_writer.cc
index 88986561c31ce2c5c4c03d211b9acd52d8b087f2..ff3531918eb13f9e6681f6c65e51b1669ef70165 100644
--- a/minidump/minidump_file_writer.cc
+++ b/minidump/minidump_file_writer.cc
@@ -17,6 +17,7 @@
#include "base/logging.h"
#include "minidump/minidump_crashpad_info_writer.h"
#include "minidump/minidump_exception_writer.h"
+#include "minidump/minidump_handle_writer.h"
#include "minidump/minidump_memory_info_writer.h"
#include "minidump/minidump_memory_writer.h"
#include "minidump/minidump_misc_info_writer.h"
@@ -108,6 +109,13 @@ void MinidumpFileWriter::InitializeFromSnapshot(
AddStream(memory_info_list.Pass());
}
+ std::vector<HandleSnapshot> handles_snapshot = process_snapshot->Handles();
+ if (!handles_snapshot.empty()) {
+ auto handle_data_writer = make_scoped_ptr(new MinidumpHandleDataWriter());
+ handle_data_writer->InitializeFromSnapshot(handles_snapshot);
+ AddStream(handle_data_writer.Pass());
+ }
+
memory_list->AddFromSnapshot(process_snapshot->ExtraMemory());
AddStream(memory_list.Pass());

Powered by Google App Engine
This is Rietveld 408576698