Write MINIDUMP_HANDLE_DATA_STREAM to minidump

snapshot/win/end_to_end_test.py

 #!/usr/bin/env python
 
 # Copyright 2015 The Crashpad Authors. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
@@ skipping 165 matching lines @@
 
   out = CdbRun(cdb_path, dump_path, '!gle')
   out.Check('LastErrorValue: \(Win32\) 0x2 \(2\) - The system cannot find the '
             'file specified.', '!gle gets last error')
   out.Check('LastStatusValue: \(NTSTATUS\) 0xc000000f - {File Not Found}  The '
             'file %hs does not exist.', '!gle gets last ntstatus')
 
   out = CdbRun(cdb_path, dump_path, '!locks')
   out.Check(r'CritSec crashy_program!crashpad::`anonymous namespace\'::'
             r'g_test_critical_section', 'lock was captured')
-  if float(platform.win32_ver()[0]) != 7:
+  if platform.win32_ver()[0] != '7':
     # We can't allocate CRITICAL_SECTIONs with .DebugInfo on Win 7.
     out.Check(r'\*\*\* Locked', 'lock debug info was captured, and is locked')
 
+  out = CdbRun(cdb_path, dump_path, '!handle')
+  out.Check(r'\d+ Handles', 'captured handles')
+  out.Check(r'Event\s+\d+', 'capture some event handles')
+  out.Check(r'File\s+\d+', 'capture some file handles')
 
 def main(args):
   try:
     if len(args) != 1:
       print >>sys.stderr, 'must supply binary dir'
       return 1
 
     cdb_path = GetCdbPath()
     if not cdb_path:
       print >>sys.stderr, 'could not find cdb'
       return 1
 
     # Make sure we can download Windows symbols.
     if not os.environ.get('_NT_SYMBOL_PATH'):
       symbol_dir = MakeTempDir()
+      protocol = 'https' if platform.win32_ver()[0] != 'XP' else 'http'

[Mark Mentovai, 2015/10/21 00:04:21]

Oh no, poor XP!

[scottmg, 2015/10/21 00:14:15]

Yeah, took me a while to realize what was going on when it couldn't get symbols
on the XP box.

       os.environ['_NT_SYMBOL_PATH'] = (
-          'SRV*' + symbol_dir + '*https://msdl.microsoft.com/download/symbols')
+          'SRV*' + symbol_dir + '*' +
+          protocol + '://msdl.microsoft.com/download/symbols')
 
     pipe_name = r'\\.\pipe\end-to-end_%s_%s' % (
         os.getpid(), str(random.getrandbits(64)))
 
     dump_path = GetDumpFromCrashyProgram(args[0], pipe_name)
     if not dump_path:
       return 1
 
     RunTests(cdb_path, dump_path, pipe_name)
 
     return 0
   finally:
     CleanUpTempDirs()
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))