Write MINIDUMP_HANDLE_DATA_STREAM to minidump

minidump/minidump_string_writer_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 35 matching lines @@
     EXPECT_TRUE(string_writer.WriteEverything(&string_file));
     ASSERT_EQ(6u, string_file.string().size());
 
     const MINIDUMP_STRING* minidump_string =
         MinidumpStringAtRVA(string_file.string(), 0);
     EXPECT_TRUE(minidump_string);
     EXPECT_EQ(base::string16(),
               MinidumpStringAtRVAAsString(string_file.string(), 0));
   }
 
+  {
+    SCOPED_TRACE("no conversion");
+    string_file.Reset();
+    crashpad::internal::MinidumpUTF16StringWriter string_writer;
+    const base::string16 kString(L"oóöőo");

[Mark Mentovai, 2015/10/21 16:53:51]

This was inspired by all of the different kinds of O they have in Hungarian.
True story.

+    string_writer.SetUTF16(kString);
+    EXPECT_TRUE(string_writer.WriteEverything(&string_file));
+    ASSERT_EQ(
+        sizeof(MINIDUMP_STRING) + (kString.size() + 1) * sizeof(kString[0]),
+        string_file.string().size());
+
+    const MINIDUMP_STRING* minidump_string =
+        MinidumpStringAtRVA(string_file.string(), 0);
+    EXPECT_TRUE(minidump_string);
+    EXPECT_EQ(kString, MinidumpStringAtRVAAsString(string_file.string(), 0));
+  }
+
   const struct {
     size_t input_length;
     const char* input_string;
     size_t output_length;
     base::char16 output_string[10];
   } kTestData[] = {
       {0, "", 0, {}},
       {1, "a", 1, {'a'}},
       {2, "\0b", 2, {0, 'b'}},
       {3, "cde", 3, {'c', 'd', 'e'}},
@@ skipping 193 matching lines @@
   MinidumpStringListTest<MinidumpUTF16StringListWriterTraits>();
 }
 
 TEST(MinidumpStringWriter, MinidumpUTF8StringList) {
   MinidumpStringListTest<MinidumpUTF8StringListWriterTraits>();
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad