[Extensions Toolbar] Fix action pop out bug and views animation

[Extensions Toolbar] Fix action pop out bug and views animation

If the main toolbar container changes size when the chrome menu is open, the
overflow container in the chrome menu needs to also change size. (This can
happen when an action is popped out to show the pop up, and then the popup is
closed by opening the chrome menu.)

Also smooth out the animation on Views platforms - this is fixed by not
adjusting the size in Redraw(), since the size should only be adjusted in
ResizeAndAnimate().

BUG=546646
BUG=546647
TBR=sky@chromium.org (browser_actions_container_observer removal)

Committed: https://crrev.com/7699d8bbbb0c8bd33222055b52762c8b19414f99
Cr-Commit-Position: refs/heads/master@{#355847}

[Devlin, 2015-10-22 17:04:52]

Description was changed from

==========
Somethign to test

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Somethign to test

BUG=
==========

[Devlin, 2015-10-22 17:40:18]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-10-22 17:40:22]

Patchset #1 (id:20001) has been deleted

[Devlin, 2015-10-22 17:40:27]

Patchset #1 (id:40001) has been deleted

[Devlin, 2015-10-22 17:40:33]

Patchset #1 (id:60001) has been deleted

[Devlin, 2015-10-22 17:40:52]

Description was changed from

==========
Somethign to test

BUG=
==========

to

==========
[Extensions Toolbar] Fix action pop out bug and views animation

If the main toolbar container changes size when the chrome menu is open, the
overflow container in the chrome menu needs to also change size. (This can
happen when an action is popped out to show the pop up, and then the popup is
closed by opening the chrome menu.)

Also smooth out the animation on Views platforms - this is fixed by not
adjusting the size in Redraw(), since the size should only be adjusted in
ResizeAndAnimate().

BUG=546646
BUG=546647
==========

[Devlin, 2015-10-22 17:40:52]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org, finnur@chromium.org

[Devlin, 2015-10-22 19:58:24]

Finnur (everything but the Cocoa) and Avi (the Cocoa), mind taking a look?

[Avi (use Gerrit), 2015-10-22 21:32:02]

lgtm with comment nits

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h (right):

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h:33: class
ToolbarActionsBarObserverHelper;
alphabetize

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (right):

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:127: // being
added or removed), We need to re-layout the menu in order to resize
lower-case "we"

[Devlin, 2015-10-22 22:18:05]

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h (right):

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h:33: class
ToolbarActionsBarObserverHelper;
On 2015/10/22 21:32:02, Avi wrote:
> alphabetize

Done.

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (right):

https://codereview.chromium.org/1419603004/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc:127: // being
added or removed), We need to re-layout the menu in order to resize
On 2015/10/22 21:32:02, Avi wrote:
> lower-case "we"

Whoops, done.

[Finnur, 2015-10-23 11:50:02]

LGTM

[Devlin, 2015-10-23 18:23:54]

Description was changed from

==========
[Extensions Toolbar] Fix action pop out bug and views animation

If the main toolbar container changes size when the chrome menu is open, the
overflow container in the chrome menu needs to also change size. (This can
happen when an action is popped out to show the pop up, and then the popup is
closed by opening the chrome menu.)

Also smooth out the animation on Views platforms - this is fixed by not
adjusting the size in Redraw(), since the size should only be adjusted in
ResizeAndAnimate().

BUG=546646
BUG=546647
==========

to

==========
[Extensions Toolbar] Fix action pop out bug and views animation

If the main toolbar container changes size when the chrome menu is open, the
overflow container in the chrome menu needs to also change size. (This can
happen when an action is popped out to show the pop up, and then the popup is
closed by opening the chrome menu.)

Also smooth out the animation on Views platforms - this is fixed by not
adjusting the size in Redraw(), since the size should only be adjusted in
ResizeAndAnimate().

BUG=546646
BUG=546647
TBR=sky@chromium.org (browser_actions_container_observer removal)
==========

[Devlin, 2015-10-23 18:24:07]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-10-23 18:24:08]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1419603004/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-23 18:24:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419603004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419603004/140001

[commit-bot: I haz the power, 2015-10-23 18:49:04]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-10-23 18:50:21]

Patchset 4 (id:??) landed as
https://crrev.com/7699d8bbbb0c8bd33222055b52762c8b19414f99
Cr-Commit-Position: refs/heads/master@{#355847}