Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: tests/OncePtrTest.cpp

Issue 1419593004: Avoid hang in OncePtr test with --threads 1 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkTaskGroup.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/OncePtrTest.cpp
diff --git a/tests/OncePtrTest.cpp b/tests/OncePtrTest.cpp
index b1e4e5d1ae7d3ec238a324201db3bb0d9ae7dd11..103172751a792a756be33692cf5120e814c2da76 100644
--- a/tests/OncePtrTest.cpp
+++ b/tests/OncePtrTest.cpp
@@ -18,8 +18,10 @@ DEF_TEST(OncePtr, r) {
return new int(5);
};
- SkAtomic<int> force_a_race(sk_num_cores());
-
+ SkAtomic<int> force_a_race(sk_parallel_for_thread_count());
+ if (force_a_race < 1) {
+ return;
+ }
sk_parallel_for(sk_num_cores()*4, [&](size_t) {
force_a_race.fetch_add(-1);
while (force_a_race.load() > 0);
« no previous file with comments | « src/core/SkTaskGroup.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698