Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: tests/OncePtrTest.cpp

Issue 1419593004: Avoid hang in OncePtr test with --threads 1 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: address review comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkTaskGroup.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "Test.h" 8 #include "Test.h"
9 #include "SkCommonFlags.h"
Kimmo Kinnunen 2015/10/27 14:23:12 forgot to remove this..
9 #include "SkOncePtr.h" 10 #include "SkOncePtr.h"
10 #include "SkTaskGroup.h" 11 #include "SkTaskGroup.h"
11 12
12 DEF_TEST(OncePtr, r) { 13 DEF_TEST(OncePtr, r) {
13 SkOncePtr<int> once; 14 SkOncePtr<int> once;
14 15
15 static SkAtomic<int> calls(0); 16 static SkAtomic<int> calls(0);
16 auto create = [&] { 17 auto create = [&] {
17 calls.fetch_add(1); 18 calls.fetch_add(1);
18 return new int(5); 19 return new int(5);
19 }; 20 };
20 21
21 SkAtomic<int> force_a_race(sk_num_cores()); 22 SkAtomic<int> force_a_race(sk_parallel_for_thread_count());
22 23 if (force_a_race < 1) {
24 return;
25 }
23 sk_parallel_for(sk_num_cores()*4, [&](size_t) { 26 sk_parallel_for(sk_num_cores()*4, [&](size_t) {
24 force_a_race.fetch_add(-1); 27 force_a_race.fetch_add(-1);
25 while (force_a_race.load() > 0); 28 while (force_a_race.load() > 0);
26 29
27 int* n = once.get(create); 30 int* n = once.get(create);
28 REPORTER_ASSERT(r, *n == 5); 31 REPORTER_ASSERT(r, *n == 5);
29 }); 32 });
30 REPORTER_ASSERT(r, calls.load() == 1); 33 REPORTER_ASSERT(r, calls.load() == 1);
31 } 34 }
32 35
33 /* TODO(mtklein): next CL 36 /* TODO(mtklein): next CL
34 37
35 SK_DECLARE_STATIC_ONCE(once_noptr); 38 SK_DECLARE_STATIC_ONCE(once_noptr);
36 DEF_TEST(OnceNoPtr, r) { 39 DEF_TEST(OnceNoPtr, r) {
37 static SkAtomic<int> calls(0); 40 static SkAtomic<int> calls(0);
38 41
39 SkAtomic<int> force_a_race(sk_num_cores()); 42 SkAtomic<int> force_a_race(sk_num_cores());
40 sk_parallel_for(sk_num_cores()*4, [&](size_t) { 43 sk_parallel_for(sk_num_cores()*4, [&](size_t) {
41 force_a_race.fetch_add(-1); 44 force_a_race.fetch_add(-1);
42 while (force_a_race.load() > 0); 45 while (force_a_race.load() > 0);
43 46
44 SkOnce(&once_noptr, [&] { calls.fetch_add(1); }); 47 SkOnce(&once_noptr, [&] { calls.fetch_add(1); });
45 }); 48 });
46 REPORTER_ASSERT(r, calls.load() == 1); 49 REPORTER_ASSERT(r, calls.load() == 1);
47 } 50 }
48 */ 51 */
OLDNEW
« no previous file with comments | « src/core/SkTaskGroup.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698