Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1419593003: Force the s4 to use highp for transforming to NDS (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 2 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org, caryclark
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Force the s4 to use highp for transforming to NDS This seems to fix some rendering issues. Currently this will use highp for all draws on the s4, but if we see perf issues we can refine this later to specific types of draws. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cae0085accd0b241d883770fe17d4161f56d68ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
egdaniel
this is based on the gold images we looked at
5 years, 2 months ago (2015-10-22 17:00:49 UTC) #2
bsalomon
lgtm
5 years, 2 months ago (2015-10-22 17:58:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419593003/1
5 years, 2 months ago (2015-10-22 17:58:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cae0085accd0b241d883770fe17d4161f56d68ae
5 years, 2 months ago (2015-10-22 18:08:15 UTC) #6
reed1
5 years, 2 months ago (2015-10-22 22:45:24 UTC) #8
Message was sent while issue was closed.
Could this change possibly have affected this (failing) chrome test?

http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...

Powered by Google App Engine
This is Rietveld 408576698