Issue 1419583008: Add icu_assets GN rule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1419583008: Add icu_assets GN rule (Closed)

Created:
5 years, 1 month ago by pkotwicz

Modified:
5 years, 1 month ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, agrieve

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add icu_assets GN rule The new GN rule will enable removal of code which copies icudtl.dat in Android GN code (for instance "copy_content_shell_assets"). BUG=547162 R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/42c58d4e49f2250039f0e98d43e0b76e8f5ca024

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	BUILD.gn	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

pkotwicz

5 years, 1 month ago (2015-11-03 22:35:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
42c58d4e49f2250039f0e98d43e0b76e8f5ca024 (presubmit successful).