Make content_unittests not crash on GN Android

Make content_unittests not crash on GN Android

BUG=510485
Committed: https://crrev.com/86ef231cbe4c52bede41d583519898a9a345c987
Cr-Commit-Position: refs/heads/master@{#355879}

[pkotwicz, 2015-10-21 00:08:46]

pkotwicz@chromium.org changed reviewers:
+ agrieve@chromium.org

[pkotwicz, 2015-10-21 00:08:46]

agrieve@ PTAL

[agrieve, 2015-10-21 01:13:01]

lgtm

https://codereview.chromium.org/1419583005/diff/1/content/test/BUILD.gn
File content/test/BUILD.gn (right):

https://codereview.chromium.org/1419583005/diff/1/content/test/BUILD.gn#newco...
content/test/BUILD.gn:486: content_unittests_apk_assets_dir =
nit: prefix non-parameter variables with a _

https://codereview.chromium.org/1419583005/diff/1/content/test/BUILD.gn#newco...
content/test/BUILD.gn:490: dest = "$content_unittests_apk_assets_dir"
nit: no need for ""s

https://codereview.chromium.org/1419583005/diff/1/content/test/BUILD.gn#newco...
content/test/BUILD.gn:683: apk_asset_location =
"$content_unittests_apk_assets_dir"
nit: drop the "$", just do apk_asset_location = content_unittests_apk_assets_dir

[pkotwicz, 2015-10-21 02:04:57]

sievers@ for OWNERS

[pkotwicz, 2015-10-21 02:05:06]

Description was changed from

==========
Make content_unittests not crash on GN Android

BUG=510485
==========

to

==========
Make content_unittests not crash on GN Android

BUG=510485
==========

[pkotwicz, 2015-10-21 02:05:07]

pkotwicz@chromium.org changed reviewers:
+ sievers@chromium.org

[pkotwicz, 2015-10-23 14:11:07]

sievers@ Ping!

[no sievers, 2015-10-23 15:51:12]

On 2015/10/23 14:11:07, pkotwicz wrote:
> sievers@ Ping!

lgtm

[pkotwicz, 2015-10-23 20:09:20]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-10-23 20:09:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1419583005/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-10-23 20:10:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419583005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419583005/60001

[commit-bot: I haz the power, 2015-10-23 20:58:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-23 20:59:32]

Patchset 4 (id:??) landed as
https://crrev.com/86ef231cbe4c52bede41d583519898a9a345c987
Cr-Commit-Position: refs/heads/master@{#355879}