Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1419583002: Remove SVG glyph-orientation-horizontal and glyph-orientation-vertical (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove glyph-orientation-rounding-test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
index c1f1b73ff4d561fd714fcdf87e4c2c992fd44a1a..d20b730c96405877bce6da52efa62def0d091714 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
@@ -1149,22 +1149,6 @@ static PassRefPtrWillBeRawPtr<CSSValueList> valueForBorderRadiusShorthand(const
return list.release();
}
-static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> glyphOrientationToCSSPrimitiveValue(EGlyphOrientation orientation)
-{
- switch (orientation) {
- case GO_0DEG:
- return CSSPrimitiveValue::create(0.0f, CSSPrimitiveValue::UnitType::Degrees);
- case GO_90DEG:
- return CSSPrimitiveValue::create(90.0f, CSSPrimitiveValue::UnitType::Degrees);
- case GO_180DEG:
- return CSSPrimitiveValue::create(180.0f, CSSPrimitiveValue::UnitType::Degrees);
- case GO_270DEG:
- return CSSPrimitiveValue::create(270.0f, CSSPrimitiveValue::UnitType::Degrees);
- default:
- return nullptr;
- }
-}
-
static PassRefPtrWillBeRawPtr<CSSValue> strokeDashArrayToCSSValueList(const SVGDashArray& dashes, const ComputedStyle& style)
{
if (dashes.isEmpty())
@@ -2618,15 +2602,6 @@ PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::get(CSSPropertyID
}
case CSSPropertyBufferedRendering:
return CSSPrimitiveValue::create(svgStyle.bufferedRendering());
- case CSSPropertyGlyphOrientationHorizontal:
- return glyphOrientationToCSSPrimitiveValue(svgStyle.glyphOrientationHorizontal());
- case CSSPropertyGlyphOrientationVertical: {
- if (RefPtrWillBeRawPtr<CSSPrimitiveValue> value = glyphOrientationToCSSPrimitiveValue(svgStyle.glyphOrientationVertical()))
- return value.release();
- if (svgStyle.glyphOrientationVertical() == GO_AUTO)
- return CSSPrimitiveValue::createIdentifier(CSSValueAuto);
- return nullptr;
- }
case CSSPropertyPaintOrder:
return paintOrderToCSSValueList(svgStyle);
case CSSPropertyVectorEffect:

Powered by Google App Engine
This is Rietveld 408576698