Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419583002: Remove SVG glyph-orientation-horizontal and glyph-orientation-vertical (Closed)

Created:
5 years, 2 months ago by kojii
Modified:
5 years, 2 months ago
Reviewers:
Timothy Loh, fs
CC:
fs, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVG glyph-orientation-horizontal and glyph-orientation-vertical This patch removes the SVG glyph-orientation-horizontal and glyph-orientation-vertical properties. These properties are no longer used by the switch to the CSS text-orientation property[1]. This patch removes these properties from the parser and computed styles. [1] https://codereview.chromium.org/1404853003/ BUG=543397 Committed: https://crrev.com/c965bbd594a5c94924bfee72270af052fc0d851b Cr-Commit-Position: refs/heads/master@{#355181}

Patch Set 1 #

Patch Set 2 : -expected updated #

Total comments: 1

Patch Set 3 : Remove glyph-orientation-rounding-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -548 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml View 1 2 1 chunk +0 lines, -124 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt View 1 2 1 chunk +0 lines, -320 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyle.h View 6 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyleDefs.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAttributeNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kojii
PTAL. Tim, can you review css & style? fs, can you review svg?
5 years, 2 months ago (2015-10-20 06:56:38 UTC) #4
Timothy Loh
lgtm!
5 years, 2 months ago (2015-10-20 07:18:41 UTC) #5
fs
lgtm https://codereview.chromium.org/1419583002/diff/20001/third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt File third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt (right): https://codereview.chromium.org/1419583002/diff/20001/third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt#newcode1 third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt:1: Stress test glyph-orientation SVG CSS properties Could also ...
5 years, 2 months ago (2015-10-20 08:08:16 UTC) #6
kojii
On 2015/10/20 08:08:16, fs wrote: > lgtm > > https://codereview.chromium.org/1419583002/diff/20001/third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt > File > third_party/WebKit/LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt > ...
5 years, 2 months ago (2015-10-20 22:43:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419583002/40001
5 years, 2 months ago (2015-10-20 22:43:56 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-20 23:08:47 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 23:09:35 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c965bbd594a5c94924bfee72270af052fc0d851b
Cr-Commit-Position: refs/heads/master@{#355181}

Powered by Google App Engine
This is Rietveld 408576698