[sql] QuotaDatabase schema upgrade doesn't use transactions right.

[sql] QuotaDatabase schema upgrade doesn't use transactions right.

BUG=548371
Committed: https://crrev.com/dea7ae9bd84c6e66f74351f3af1368226ce2de17
Cr-Commit-Position: refs/heads/master@{#356675}

[michaeln, 2015-10-28 01:15:00]

michaeln@chromium.org changed reviewers:
+ shess@chromium.org

[michaeln, 2015-10-28 01:15:01]

ptal

[michaeln, 2015-10-28 01:15:22]

Description was changed from

==========
quotaDB

BUG=548371
==========

to

==========
[sql] QuotaDatabase schema upgrade doesn't use transactions right.

BUG=548371
==========

[Scott Hess - ex-Googler, 2015-10-28 20:56:11]

LGTM.

Might be worthwhile to have a long-term aim to commit to running everything
under your long-running-transaction, just to prevent errors.

Or ... would you be interested in dog-fooding WAL?  With that you'd use regular
local transactions, and replace your scheduled routine with a WAL checkpoint. 
Or you could ignore the checkpoint and let things checkpoint based on -wal size.
 I've been experimenting with it a bit, but haven't actually done anything
concrete due to lack of available focus.  If anyone would be available to
refactor on your end (or review changes I make), let me know and I can pull
together my notes and land some initial support in sql/ .

[michaeln, 2015-10-28 21:26:56]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2015-10-28 21:28:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419573008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419573008/1

[commit-bot: I haz the power, 2015-10-28 22:43:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-28 22:44:13]

Patchset 1 (id:??) landed as
https://crrev.com/dea7ae9bd84c6e66f74351f3af1368226ce2de17
Cr-Commit-Position: refs/heads/master@{#356675}