Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1419563006: X87: Remove receiver conversion from function prologue. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove receiver conversion from function prologue. port 4ab1b05d5ec15f25085383e34e3b326bdbf990fc (r31826). original commit message: Depends on https://codereview.chromium.org/1407373007/ After that CL, all receiver conversion is handled by the call builtin. BUG= Committed: https://crrev.com/da72ba0b3eef3556ed6b6e7428cc4a652925d75c Cr-Commit-Position: refs/heads/master@{#31849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -36 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +4 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-06 02:51:55 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-06 02:53:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419563006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419563006/1
5 years, 1 month ago (2015-11-06 02:53:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 03:12:17 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 03:12:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da72ba0b3eef3556ed6b6e7428cc4a652925d75c
Cr-Commit-Position: refs/heads/master@{#31849}

Powered by Google App Engine
This is Rietveld 408576698