Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1419563004: Simplify IdentityMap. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify IdentityMap. This removes the requirement for handles as arguments, but also removes concurrency support, which is not being used at the moment. Supporting concurrency could be done by introducing a sibling class to IdentityMap that includes RelocationLock on method calls. R=bmeurer@chromium.org, ulan@chromium.org Committed: https://crrev.com/05a60095446f36399208be2041f5a51e63d34bbe Cr-Commit-Position: refs/heads/master@{#31510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -49 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/identity-map.h View 5 chunks +10 lines, -16 lines 0 comments Download
M src/identity-map.cc View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Yang
Benedikt, this is what we talked about. Ulan, please look at the heap changes.
5 years, 1 month ago (2015-10-23 08:21:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419563004/1
5 years, 1 month ago (2015-10-23 08:21:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-23 08:44:02 UTC) #5
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-10-23 09:07:22 UTC) #6
ulan
heap part lgtm
5 years, 1 month ago (2015-10-23 09:57:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419563004/1
5 years, 1 month ago (2015-10-23 10:31:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-23 10:32:48 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-23 10:33:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05a60095446f36399208be2041f5a51e63d34bbe
Cr-Commit-Position: refs/heads/master@{#31510}

Powered by Google App Engine
This is Rietveld 408576698