sse 4.2 detection

sse 4.2 detection

While we're detecting instruction sets, let's fill in this hole too.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/953549235ddaaf4e670b44bd69efa1ac1c835be0

[mtklein_C, 2015-11-07 16:26:32]

mtklein@chromium.org changed reviewers:
+ msarett@chromium.org

[mtklein_C, 2015-11-07 16:26:32]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2015-11-07 16:26:32]

Considerably simpler than AVX!

[commit-bot: I haz the power, 2015-11-07 16:26:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419553007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419553007/1

[commit-bot: I haz the power, 2015-11-07 16:26:44]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-11-07 22:26 UTC

[commit-bot: I haz the power, 2015-11-07 22:26:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-07 22:26:04]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[msarett, 2015-11-09 14:42:54]

msarett@google.com changed reviewers:
+ msarett@google.com

[msarett, 2015-11-09 14:42:55]

lgtm

[mtklein, 2015-11-09 14:57:39]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-11-09 14:57:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419553007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419553007/1

[commit-bot: I haz the power, 2015-11-09 15:08:39]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/953549235ddaaf4e670b44bd69efa1ac1c835be0

[Lei Zhang, 2015-11-17 00:11:32]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-11-17 00:11:32]

https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp
File src/core/SkOpts.cpp (right):

https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp#newcode86
src/core/SkOpts.cpp:86: void Init_sse42() { SkDEBUGCODE( SkDebugf("sse 4.2
detected\n"); ) }
These are a wee bit spammy in debug builds. Every Chromium process that starts
up ends up printing this.

https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp#newcode90
src/core/SkOpts.cpp:90: //TODO: _dsp2, _armv7, _armv8, _x86, _x86_64, _sse42,
... ?
Remove sse42 from this list now?

[mtklein, 2015-11-17 00:12:13]

On 2015/11/17 at 00:11:32, thestig wrote:
> https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp
> File src/core/SkOpts.cpp (right):
> 
>
https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp#newcode86
> src/core/SkOpts.cpp:86: void Init_sse42() { SkDEBUGCODE( SkDebugf("sse 4.2
detected\n"); ) }
> These are a wee bit spammy in debug builds. Every Chromium process that starts
up ends up printing this.

Oh, didn't realize you guys had SkDebugf turned on.  I'll remove them.

>
https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp#newcode90
> src/core/SkOpts.cpp:90: //TODO: _dsp2, _armv7, _armv8, _x86, _x86_64, _sse42,
... ?
> Remove sse42 from this list now?

[mtklein, 2015-11-17 00:12:14]

On 2015/11/17 at 00:11:32, thestig wrote:
> https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp
> File src/core/SkOpts.cpp (right):
> 
>
https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp#newcode86
> src/core/SkOpts.cpp:86: void Init_sse42() { SkDEBUGCODE( SkDebugf("sse 4.2
detected\n"); ) }
> These are a wee bit spammy in debug builds. Every Chromium process that starts
up ends up printing this.

Oh, didn't realize you guys had SkDebugf turned on.  I'll remove them.

>
https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp#newcode90
> src/core/SkOpts.cpp:90: //TODO: _dsp2, _armv7, _armv8, _x86, _x86_64, _sse42,
... ?
> Remove sse42 from this list now?

[Lei Zhang, 2015-11-17 00:14:51]

On 2015/11/17 00:12:13, mtklein wrote:
> On 2015/11/17 at 00:11:32, thestig wrote:
> > https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp
> > File src/core/SkOpts.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1419553007/diff/1/src/core/SkOpts.cpp#newcode86
> > src/core/SkOpts.cpp:86: void Init_sse42() { SkDEBUGCODE( SkDebugf("sse 4.2
> detected\n"); ) }
> > These are a wee bit spammy in debug builds. Every Chromium process that
starts
> up ends up printing this.
> 
> Oh, didn't realize you guys had SkDebugf turned on.  I'll remove them.

This is just a plain Debug build of Chromium. The bots OTOH, do Release builds
with DCHECKs turned on.