Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1419553005: VM: Don't rely on always running constant propagation in the optimizer (Closed)

Created:
5 years, 1 month ago by Florian Schneider
Modified:
5 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Don't rely on always running constant propagation in the optimizer When inlining functions that unconditionally throw (have zero normal returns), the optimizer inserts a branch with a true condition and relies on constant propagation to remove the rest of the caller which becomes unreachable after inlining. This allows to compilesuch functions without running constant propagation by replacing uses of the return value with null. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/05ad578b77d074bf620227bcf5a3e5f53c28cc32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 1 month ago (2015-10-30 21:33:15 UTC) #2
rmacnak
LGTM
5 years, 1 month ago (2015-10-30 21:45:18 UTC) #3
Florian Schneider
5 years, 1 month ago (2015-10-30 21:49:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
05ad578b77d074bf620227bcf5a3e5f53c28cc32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698