Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 1419533014: win: Fix ClockMonotonicNanoseconds() (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M util/misc/clock_win.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-11-05 18:33:49 UTC) #2
scottmg
lgtm https://codereview.chromium.org/1419533014/diff/1/util/misc/clock_win.cc File util/misc/clock_win.cc (right): https://codereview.chromium.org/1419533014/diff/1/util/misc/clock_win.cc#newcode42 util/misc/clock_win.cc:42: int64_t leftover_ticks = time.QuadPart % frequency; frequency = ...
5 years, 1 month ago (2015-11-05 18:49:58 UTC) #3
Mark Mentovai
https://codereview.chromium.org/1419533014/diff/1/util/misc/clock_win.cc File util/misc/clock_win.cc (right): https://codereview.chromium.org/1419533014/diff/1/util/misc/clock_win.cc#newcode42 util/misc/clock_win.cc:42: int64_t leftover_ticks = time.QuadPart % frequency; scottmg wrote: > ...
5 years, 1 month ago (2015-11-05 18:58:10 UTC) #4
Mark Mentovai
5 years, 1 month ago (2015-11-06 15:16:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a9076656fc499044a8ed2c570b7cd523afd380d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698