Redo background compilation queues to allocate queue and its element in the C-heap

Redo background compilation queues to allocate queue and its element in the C-heap

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/720e67ea1a698a7ec07125ab5721f9e485a608a0

[srdjan, 2015-11-04 22:25:38]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-11-05 18:40:49]

lgtm

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1493: RawFunction* Function() { return
Function::RawCast(obj_); }
Does this also need to be
  return (obj_ == Object::null()) ? Function::null() : Function::RawCast(obj_);

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1494: RawCode* Code() {
RawCode* Code() const { ?
Ditto above for Function()

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1517: QueueElement* prev_;
Why do you call this prev_, it seems more like it points to the next element in
the queue so shouldn't it be next_

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1697: // false).
Now that we have the functionality of deleting the compilation queue do we still
need to wait for all compilations to finish before exiting?

[srdjan, 2015-11-05 19:19:03]

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1493: RawFunction* Function() { return
Function::RawCast(obj_); }
On 2015/11/05 18:40:48, siva wrote:
> Does this also need to be
>   return (obj_ == Object::null()) ? Function::null() :
Function::RawCast(obj_);

Functions entries  can never be NULL.

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1494: RawCode* Code() {
On 2015/11/05 18:40:48, siva wrote:
> RawCode* Code() const { ?
> Ditto above for Function()

Done.

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1517: QueueElement* prev_;
On 2015/11/05 18:40:48, siva wrote:
> Why do you call this prev_, it seems more like it points to the next element
in
> the queue so shouldn't it be next_

next_ it is.

https://codereview.chromium.org/1419533011/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1697: // false).
On 2015/11/05 18:40:48, siva wrote:
> Now that we have the functionality of deleting the compilation queue do we
still
> need to wait for all compilations to finish before exiting?

You are right. No we do not need to wait, added: while (running_ && ...)

[srdjan, 2015-11-05 20:13:49]

Committed patchset #4 (id:60001) manually as
720e67ea1a698a7ec07125ab5721f9e485a608a0 (presubmit successful).