Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1419533002: Roll android_tools deps (Closed)

Created:
5 years, 2 months ago by Yusuf
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll android_tools deps Sets the build-tools version. Renames two resources due to resource name clashes with mediarouter resources Adds recyclerview as a dependency to design in gn. BUG=537270 Committed: https://crrev.com/8356eb404a31149079621a7fe95e79bea4c9fb3e Cr-Commit-Position: refs/heads/master@{#356346}

Patch Set 1 #

Patch Set 2 : Updated config.gni #

Patch Set 3 : Update __init__.py #

Patch Set 4 : Fixed setImageResource(0) crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants/__init__.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_collapse.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/ic_collapsed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/ic_expand.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-hdpi/ic_expanded.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_collapse.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/ic_collapsed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/ic_expand.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/ic_expanded.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_collapse.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/ic_collapsed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/ic_expand.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xhdpi/ic_expanded.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_collapse.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/ic_collapsed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/ic_expand.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxhdpi/ic_expanded.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_collapse.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/ic_collapsed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/ic_expand.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-xxxhdpi/ic_expanded.png View Binary file 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 37 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419533002/1
5 years, 2 months ago (2015-10-19 23:59:55 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/146613)
5 years, 2 months ago (2015-10-20 00:16:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419533002/20001
5 years, 2 months ago (2015-10-20 17:23:01 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/84437)
5 years, 2 months ago (2015-10-20 18:22:46 UTC) #8
Yusuf
5 years, 2 months ago (2015-10-20 18:27:06 UTC) #10
gone
lgtm
5 years, 2 months ago (2015-10-20 18:29:30 UTC) #11
Yusuf
jbudorick@ for build/ changes This is for a DEPS roll to Support Library 23.1, tools ...
5 years, 2 months ago (2015-10-20 18:30:56 UTC) #13
jbudorick
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pylib/constants/__init__.py&l=158 should be changed as well.
5 years, 2 months ago (2015-10-20 18:32:48 UTC) #14
Yusuf
On 2015/10/20 18:32:48, jbudorick wrote: > https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pylib/constants/__init__.py&l=158 > should be changed as well. Done.
5 years, 2 months ago (2015-10-20 18:37:08 UTC) #15
jbudorick
build/ lgtm
5 years, 2 months ago (2015-10-20 18:38:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419533002/40001
5 years, 2 months ago (2015-10-20 18:50:09 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/84524)
5 years, 2 months ago (2015-10-20 23:05:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419533002/40001
5 years, 2 months ago (2015-10-20 23:08:25 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/84703)
5 years, 2 months ago (2015-10-21 03:11:52 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419533002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419533002/40001
5 years, 2 months ago (2015-10-21 17:57:23 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/85065)
5 years, 2 months ago (2015-10-21 22:06:03 UTC) #29
jbudorick
On 2015/10/21 22:06:03, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-21 22:13:45 UTC) #30
jbudorick
On 2015/10/21 22:13:45, jbudorick wrote: > On 2015/10/21 22:06:03, commit-bot: I haz the power wrote: ...
5 years, 2 months ago (2015-10-21 22:15:43 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419533002/60001
5 years, 1 month ago (2015-10-27 16:58:52 UTC) #34
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-27 18:19:19 UTC) #35
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/8356eb404a31149079621a7fe95e79bea4c9fb3e Cr-Commit-Position: refs/heads/master@{#356346}
5 years, 1 month ago (2015-10-27 18:20:22 UTC) #36
dcaiafa
5 years, 1 month ago (2015-10-27 19:03:43 UTC) #37
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1411783009/ by dcaiafa@chromium.org.

The reason for reverting is: Potential cause of break:

http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%....

Powered by Google App Engine
This is Rietveld 408576698