Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 141953014: Adding support for sending horizonatal mouse wheel information in Chrome ASH on Windows 8. (Closed)

Created:
6 years, 11 months ago by ananta
Modified:
6 years, 11 months ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Adding support for sending horizonatal mouse wheel information in Chrome ASH on Windows 8. Currently using the horizontal mouse wheel also causes vertical scrolling. With this change we send over a flag in the mouse messages which indicates if horizontal scrolling is being done and if yes we create the right MouseWheelEvent instance. BUG=332797 R=cpu@chromium.org, jschuh@chromium.org, sky@chromium.org, cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M ui/aura/remote_root_window_host_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 1 chunk +2 lines, -1 line 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 10 chunks +20 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ananta
6 years, 11 months ago (2014-01-18 01:43:43 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 11 months ago (2014-01-19 03:11:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/141953014/1
6 years, 11 months ago (2014-01-19 03:11:52 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=45469
6 years, 11 months ago (2014-01-19 03:27:31 UTC) #4
ananta
+sky for ui\aura OWNERS review. +jschuh for metro_viewer_messages.h
6 years, 11 months ago (2014-01-19 15:35:28 UTC) #5
sky
LGTM
6 years, 11 months ago (2014-01-21 15:43:24 UTC) #6
jschuh
ipc security lgtm
6 years, 11 months ago (2014-01-21 23:53:16 UTC) #7
ananta
6 years, 11 months ago (2014-01-23 23:46:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r246730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698