net/spdy/buffered_spdy_framer.cc - Issue 141953004: SPDY cleanup: remove credential slot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/buffered_spdy_framer.cc

Issue 141953004: SPDY cleanup: remove credential slot. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixups to get flip_in_mem_edsm_server_unittests building & passing. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/buffered_spdy_framer.cc

diff --git a/net/spdy/buffered_spdy_framer.cc b/net/spdy/buffered_spdy_framer.cc

index f1cfaed6c6f5549c5a0cf925ea9d87b8e17e6940..2c00eb69cfdab88ec0a2db866422e3fd1a1fcc83 100644

--- a/net/spdy/buffered_spdy_framer.cc

+++ b/net/spdy/buffered_spdy_framer.cc

@@ -62,7 +62,6 @@ void BufferedSpdyFramer::OnError(SpdyFramer* spdy_framer) {

void BufferedSpdyFramer::OnSynStream(SpdyStreamId stream_id,

SpdyStreamId associated_stream_id,

SpdyPriority priority,

- uint8 credential_slot,

bool fin,

bool unidirectional) {

frames_received_++;

@@ -72,7 +71,6 @@ void BufferedSpdyFramer::OnSynStream(SpdyStreamId stream_id,

control_frame_fields_->stream_id = stream_id;

control_frame_fields_->associated_stream_id = associated_stream_id;

control_frame_fields_->priority = priority;

- control_frame_fields_->credential_slot = credential_slot;

control_frame_fields_->fin = fin;

control_frame_fields_->unidirectional = unidirectional;

@@ -128,7 +126,6 @@ bool BufferedSpdyFramer::OnControlFrameHeaderData(SpdyStreamId stream_id,

visitor_->OnSynStream(control_frame_fields_->stream_id,

control_frame_fields_->associated_stream_id,

control_frame_fields_->priority,

- control_frame_fields_->credential_slot,

control_frame_fields_->fin,

control_frame_fields_->unidirectional,

headers);

@@ -246,13 +243,11 @@ SpdyFrame* BufferedSpdyFramer::CreateSynStream(

SpdyStreamId stream_id,

SpdyStreamId associated_stream_id,

SpdyPriority priority,

- uint8 credential_slot,

SpdyControlFlags flags,

const SpdyHeaderBlock* headers) {

SpdySynStreamIR syn_stream(stream_id);

syn_stream.set_associated_to_stream_id(associated_stream_id);

syn_stream.set_priority(priority);

- syn_stream.set_slot(credential_slot);

syn_stream.set_fin((flags & CONTROL_FLAG_FIN) != 0);

syn_stream.set_unidirectional((flags & CONTROL_FLAG_UNIDIRECTIONAL) != 0);

// TODO(hkhalil): Avoid copy here.

« no previous file with comments | « net/spdy/buffered_spdy_framer.h ('k') | net/spdy/buffered_spdy_framer_unittest.cc » ('j') | net/tools/flip_server/spdy_interface.cc » ('J')