Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141953004: SPDY cleanup: remove credential slot. (Closed)

Created:
6 years, 11 months ago by Johnny
Modified:
6 years, 10 months ago
Reviewers:
akalin, yhirano
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

SPDY cleanup: remove credential slot. Credential slot field has been removed from SYN_STREAM frame. This lands server change 59587408 by mlavan. Also update affected Chromium portions of QUIC & SPDY. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247849

Patch Set 1 #

Patch Set 2 : Fixups to get flip_in_mem_edsm_server_unittests building & passing. #

Total comments: 1

Patch Set 3 : Update missed path->second => path_string. #

Patch Set 4 : Fix inadvertent rebase on upstream branches. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -165 lines) Patch
M net/quic/quic_headers_stream.cc View 3 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 3 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_spdy_decompressor.cc View 3 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer.h View 3 3 chunks +0 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 3 4 chunks +0 lines, -5 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 3 1 chunk +1 line, -2 lines 0 comments Download
M net/spdy/spdy_framer.h View 3 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.cc View 3 5 chunks +5 lines, -12 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 3 9 chunks +5 lines, -72 lines 0 comments Download
M net/spdy/spdy_protocol.h View 3 4 chunks +0 lines, -6 lines 0 comments Download
M net/spdy/spdy_session.h View 3 2 chunks +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 3 3 chunks +2 lines, -5 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_stream.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 3 2 chunks +0 lines, -3 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 2 6 chunks +14 lines, -13 lines 0 comments Download
M net/tools/flip_server/spdy_interface_test.cc View 1 13 chunks +47 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Johnny
6 years, 11 months ago (2014-01-17 21:31:31 UTC) #1
akalin
lgtm
6 years, 11 months ago (2014-01-23 00:08:23 UTC) #2
Johnny
+yhirano A build error led me into flip_in_mem_edsm_server_unittests, which appears to be compiled but not ...
6 years, 11 months ago (2014-01-24 18:12:39 UTC) #3
yhirano
Thank you for doing this. lgtm https://codereview.chromium.org/141953004/diff/170002/net/tools/flip_server/spdy_interface.cc File net/tools/flip_server/spdy_interface.cc (right): https://codereview.chromium.org/141953004/diff/170002/net/tools/flip_server/spdy_interface.cc#newcode191 net/tools/flip_server/spdy_interface.cc:191: << path->second << ...
6 years, 10 months ago (2014-01-27 02:13:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/141953004/170002
6 years, 10 months ago (2014-01-29 02:22:33 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217701
6 years, 10 months ago (2014-01-29 03:12:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/141953004/170002
6 years, 10 months ago (2014-01-29 16:00:52 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217962
6 years, 10 months ago (2014-01-29 17:30:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/141953004/310001
6 years, 10 months ago (2014-01-29 22:37:18 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:11:33 UTC) #10
Message was sent while issue was closed. 
Change committed as 247849

Powered by Google App Engine
This is Rietveld 408576698