Add boolean to tell if V8 zaps allocated memory

Add boolean to tell if V8 zaps allocated memory

V8 zaps (writes 0xdeadbeef) over the mmapped regions when in debug mode.
This causes more resident size than displayed in tracing. So, This CL
adds an api to tell if zapping is done.

BUG=546492
LOG=Y

Committed: https://crrev.com/0fa11bfb8008cbc6ec9841fad941530dcd532f48
Cr-Commit-Position: refs/heads/master@{#31716}

[ssid, 2015-10-30 13:55:16]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 13:55:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419523008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419523008/1

[commit-bot: I haz the power, 2015-10-30 13:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 13:55:25]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[ssid, 2015-10-30 13:57:17]

ssid@chromium.org changed reviewers:
+ hpayer@chromium.org, rmcilroy@chromium.org

[ssid, 2015-10-30 13:57:17]

+hpayer, +rmcilroy PTAL, 3 line return to show zapping.

[ssid, 2015-10-30 13:57:31]

Description was changed from

==========
Add boolean to tell if V8 zaps memory allocated

V8 zaps (writes 0xdeadbeef) over the mmapped regions when in debug mode.
This causes more resident size than displayed in tracing. So, This CL
adds an api to tell if zapping is done.

BUG=546492
==========

to

==========
Add boolean to tell if V8 zaps allocated memory

V8 zaps (writes 0xdeadbeef) over the mmapped regions when in debug mode.
This causes more resident size than displayed in tracing. So, This CL
adds an api to tell if zapping is done.

BUG=546492
==========

[rmcilroy, 2015-10-30 14:59:00]

LGTM other than naming issue, but please wait for Hannes to review too.

https://codereview.chromium.org/1419523008/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1419523008/diff/1/include/v8.h#newcode5010
include/v8.h:5010: size_t did_zap_garbage() { return did_zap_garbage_; }
I'd call this does_zap_garbage or similar, to avoid it looking like it changes
depending on whether the most recent GC had to zap or not.

[ssid, 2015-10-30 15:02:37]

Done thanks.

https://codereview.chromium.org/1419523008/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/1419523008/diff/1/include/v8.h#newcode5010
include/v8.h:5010: size_t did_zap_garbage() { return did_zap_garbage_; }
On 2015/10/30 14:59:00, rmcilroy wrote:
> I'd call this does_zap_garbage or similar, to avoid it looking like it changes
> depending on whether the most recent GC had to zap or not.

Done.

[Hannes Payer (out of office), 2015-11-02 17:59:06]

LGTM

[ssid, 2015-11-02 18:00:09]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 18:00:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419523008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419523008/20001

[ssid, 2015-11-02 18:02:59]

Description was changed from

==========
Add boolean to tell if V8 zaps allocated memory

V8 zaps (writes 0xdeadbeef) over the mmapped regions when in debug mode.
This causes more resident size than displayed in tracing. So, This CL
adds an api to tell if zapping is done.

BUG=546492
==========

to

==========
Add boolean to tell if V8 zaps allocated memory

V8 zaps (writes 0xdeadbeef) over the mmapped regions when in debug mode.
This causes more resident size than displayed in tracing. So, This CL
adds an api to tell if zapping is done.

BUG=546492
LOG=Y
==========

[commit-bot: I haz the power, 2015-11-02 18:25:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 18:25:14]

Dry run: This issue passed the CQ dry run.

[ssid, 2015-11-02 18:25:29]

The CQ bit was checked by ssid@chromium.org

[ssid, 2015-11-02 18:25:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1419523008/#ps20001
(title: "Rename.")

[commit-bot: I haz the power, 2015-11-02 18:25:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419523008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419523008/20001

[commit-bot: I haz the power, 2015-11-02 18:26:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-02 18:27:31]

Patchset 2 (id:??) landed as
https://crrev.com/0fa11bfb8008cbc6ec9841fad941530dcd532f48
Cr-Commit-Position: refs/heads/master@{#31716}