Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1419513007: Oilpan: Introduce GCTaskRunner (Closed)

Created:
5 years, 1 month ago by haraken
Modified:
5 years, 1 month ago
Reviewers:
keishi
CC:
chromium-reviews, blink-reviews, haraken, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Introduce GCTaskRunner MessageLoopInterruptor and PendingGCRunner are always created and destroyed at the same time. This CL puts these two classes into GCTaskRunner. This CL also renames PendingGCRunner to GCTaskObserver. BUG= Committed: https://crrev.com/b11e4bb09a938dce61a8a23517c119bb3ae5eb7d Cr-Commit-Position: refs/heads/master@{#357058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -178 lines) Patch
M third_party/WebKit/Source/platform/WebThreadSupportingGC.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/heap/GCTaskRunner.h View 4 chunks +58 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/MessageLoopInterruptor.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/platform/heap/PendingGCRunner.h View 1 chunk +0 lines, -75 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/blink_heap.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 4 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
5 years, 1 month ago (2015-10-29 15:58:15 UTC) #3
keishi
LGTM
5 years, 1 month ago (2015-10-29 20:54:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419513007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419513007/1
5 years, 1 month ago (2015-10-30 05:35:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 08:23:46 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 08:24:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b11e4bb09a938dce61a8a23517c119bb3ae5eb7d
Cr-Commit-Position: refs/heads/master@{#357058}

Powered by Google App Engine
This is Rietveld 408576698