First cut at API for native Typed Arrays.

First cut at API for native Typed Arrays.

R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14476

[Dmitry Lomov (no reviews), 2013-04-26 13:53:04]

Here is another one, now for typed arrays.

[rossberg, 2013-04-29 10:50:27]

LGTM with style nits

https://codereview.chromium.org/14195034/diff/2001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode2773
src/api.cc:2773: && i::JSTypedArray::cast(*obj)->type() == typeConst,           
\
Nit: indentation (also, we usually put the && on the previous line).

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode5879
src/api.cc:5879: if (IsDeadCheck(isolate, "v8::TypedArray::BaseAddress()"))
return 0;
Nit: NULL not 0

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode5909
src/api.cc:5909: static_cast<double>(length*sizeof(ElementType)));
Nit: space around *

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode5929
src/api.cc:5929: #define TYPED_ARRAY_NEW(TypedArray, elementType, arrayType,
elementsKind)   \
Nit: ElementType, array_type, elements_kind

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:12299:
cast(isolate->AdjustAmountOfExternalAllocatedMemory(kSize)));
Nit: indentation

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:14441: int elementCount,
Nit: element_count

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:15096: template <typename ElementType, class TypedArray,
Nit: use either 'typename' or 'class' consistently

[Dmitry Lomov (no reviews), 2013-04-29 11:08:53]

https://codereview.chromium.org/14195034/diff/2001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode2773
src/api.cc:2773: && i::JSTypedArray::cast(*obj)->type() == typeConst,           
\
On 2013/04/29 10:50:27, rossberg wrote:
> Nit: indentation (also, we usually put the && on the previous line).

Done.

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode5879
src/api.cc:5879: if (IsDeadCheck(isolate, "v8::TypedArray::BaseAddress()"))
return 0;
On 2013/04/29 10:50:27, rossberg wrote:
> Nit: NULL not 0

Done.

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode5909
src/api.cc:5909: static_cast<double>(length*sizeof(ElementType)));
On 2013/04/29 10:50:27, rossberg wrote:
> Nit: space around *

Done.

https://codereview.chromium.org/14195034/diff/2001/src/api.cc#newcode5929
src/api.cc:5929: #define TYPED_ARRAY_NEW(TypedArray, elementType, arrayType,
elementsKind)   \
On 2013/04/29 10:50:27, rossberg wrote:
> Nit: ElementType, array_type, elements_kind

Done.

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:12299:
cast(isolate->AdjustAmountOfExternalAllocatedMemory(kSize)));
On 2013/04/29 10:50:27, rossberg wrote:
> Nit: indentation

Done.

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:14441: int elementCount,
On 2013/04/29 10:50:27, rossberg wrote:
> Nit: element_count

Done.

https://codereview.chromium.org/14195034/diff/2001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:15096: template <typename ElementType, class TypedArray,
On 2013/04/29 10:50:27, rossberg wrote:
> Nit: use either 'typename' or 'class' consistently

Done.

[Dmitry Lomov (no reviews), 2013-04-29 11:09:13]

Committed patchset #1 manually as r14476 (presubmit successful).