Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 14195033: MIPS: Capture receiver in generator object (Closed)

Created:
7 years, 8 months ago by palfia
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Capture receiver in generator object Port r14434 (04f254d1) Original commit message: Previously there has been no reason to context-allocate the receiver, so access to the receiver always goes through the stack. This was failing with generators, which assumed that forcing context allocation would relieve the need of storing anything but the context and the function on the stack. This CL adds a slot in generator objects to capture the receiver, and restores it when resuming a generator. BUG=v8:2355 TEST=mjsunit/harmony/generators-iteration Committed: https://code.google.com/p/v8/source/detail?r=14442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 8 months ago (2013-04-26 00:53:21 UTC) #1
Paul Lind
lgtm
7 years, 8 months ago (2013-04-26 01:41:01 UTC) #2
palfia
7 years, 8 months ago (2013-04-26 02:07:52 UTC) #3
Message was sent while issue was closed.
Committed manually as r14442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698