plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ArrayValue.java - Issue 14195023: Fix number property sorting and optimize hasProperty call in Debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ArrayValue.java

Issue 14195023: Fix number property sorting and optimize hasProperty call in Debugger (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ArrayValue.java

diff --git a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ArrayValue.java b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ArrayValue.java

index ca1379274ee725db4a667ba15fd3247a81f3ed84..125dce9f3b8a3092550afd8817a3a23cd362e55a 100755

--- a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ArrayValue.java

+++ b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ArrayValue.java

@@ -70,7 +70,8 @@ public class ArrayValue extends Value implements IIndexedValue {

@Override

public boolean hasVariables() throws DebugException {

- return getElements().length > 0;

+ // Being optimistic. Too complicated to check accurately.

+ return true;

}

private static final Set<String> ARRAY_HIDDEN_PROPERTY_NAMES = Collections.singleton("length");

« no previous file with comments | « no previous file | plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java » ('j') | no next file with comments »