Issue 14195014: ui: Use RectF::x/y/right/bottom for rect conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14195014: ui: Use RectF::x/y/right/bottom for rect conversions. (Closed)

Created:
7 years, 8 months ago by reveman

Modified:
7 years, 8 months ago

Reviewers:
danakj, sky

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui: Use RectF::x/y/right/bottom for rect conversions. R=danakj BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194750

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	ui/gfx/rect_conversions.cc	View	1	2 chunks	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danakj

https://codereview.chromium.org/14195014/diff/1/ui/gfx/rect_conversions.cc File ui/gfx/rect_conversions.cc (right): https://codereview.chromium.org/14195014/diff/1/ui/gfx/rect_conversions.cc#newcode58 ui/gfx/rect_conversions.cc:58: ToFlooredInt(rect.right()), wait, this one is width.

7 years, 8 months ago (2013-04-17 21:13:05 UTC) #2

reveman

7 years, 8 months ago (2013-04-17 21:19:25 UTC) #3

reveman

7 years, 8 months ago (2013-04-18 02:11:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r194750 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14195014: ui: Use RectF::x/y/right/bottom for rect conversions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages